Skip to content

tests: Update showcase test to include service name in resource extraction#12665

Merged
blakeli0 merged 1 commit intomainfrom
stabilization-otel-tests
Apr 3, 2026
Merged

tests: Update showcase test to include service name in resource extraction#12665
blakeli0 merged 1 commit intomainfrom
stabilization-otel-tests

Conversation

@blakeli0
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 commented Apr 3, 2026

This PR updates showcase test to include service name in resource name extraction.

@blakeli0 blakeli0 requested a review from a team as a code owner April 3, 2026 02:12
@blakeli0 blakeli0 changed the title Stabilize OTel integration tests and fix service name propagation tests: Update showcase test to include service name in resource extraction Apr 3, 2026
@blakeli0 blakeli0 requested a review from lqiu96 April 3, 2026 02:15
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors OpenTelemetry integration tests by updating resource name constants and improving client initialization. Specifically, it updates the VALUE_TEST_USER constant to a fully qualified format and introduces helper methods and a custom stub settings class for the Identity service in ITOtelTracing.java to ensure the service name is correctly set. Additionally, the PR includes minor code style improvements, such as removing unused imports and reformatting long lines in ITOtelGoldenMetrics.java and TestClientInitializer.java. I have no feedback to provide as there were no review comments to evaluate.

@blakeli0 blakeli0 requested a review from diegomarquezp April 3, 2026 16:58
@blakeli0 blakeli0 merged commit 52e041a into main Apr 3, 2026
123 of 126 checks passed
@blakeli0 blakeli0 deleted the stabilization-otel-tests branch April 3, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants